Support naming migrations sequentially #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
requested changes
Jul 14, 2023
abonander
requested changes
Jul 21, 2023
There was a problem hiding this comment.
It's probably important to actually document the inference behavior so people know about it.
Please check the comment on the first last suggestion (always forget they appear in order of creation) before applying it.
For good measure, I checked to make sure this renders well when running sqlx migrate add --help.
|
@abonander thank you for doc suggestions; I applied them in https://github.com/vmax/sqlx/pull/2602/commits/b58fe54a4e84eb138ec8395fac966afbd169e96c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from Django migrations, I got used to migrations being named sequentially so I decided to implement support for it in
sqlx. Timestamp-based naming stays as the default; sequential naming is enabled with-sflag tosqlx migrate add.